fix: ignore disabled series in stacked bar values #116
Conversation
|
Master is back! Build not broken anymore. Please rebase and push again. |
etr2460
force-pushed
the
erik-ritter--correct-stacked-bar-values-sum
branch
from
a8a96a6
to
7d4fd97
Compare
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
=======================================
Coverage 19.87% 19.87%
=======================================
Files 8 8
Lines 161 161
Branches 10 10
=======================================
Hits 32 32
Misses 128 128
Partials 1 1
Continue to review full report at Codecov.
|
etr2460
force-pushed
the
erik-ritter--correct-stacked-bar-values-sum
branch
2 times, most recently
from
0cac6c1
to
279b7c6
Compare
|
I'm also removing some of the test data for nvd3 bar charts since they weren't formatting very well in storybook |
|
Deploy preview for superset-ui-plugins ready! Built with commit 8f251d0 |
|
@kristw this should be good for review now |
|
I'll need you to merge it too since I don't have write access |
|
The build failed :( |
|
They weren’t due to changes in anything I touched though, were they? It looked like lint errors in other files |
|
Minor linting. I will take a look when i can
…On Jun 7, 2019, 18:20 -0700, Erik Ritter ***@***.***>, wrote:
They weren’t due to changes in anything I touched though, were they? It looked like lint errors in other files
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
etr2460
force-pushed
the
erik-ritter--correct-stacked-bar-values-sum
branch
3 times, most recently
from
8f251d0
to
f61f7c1
Compare
etr2460
force-pushed
the
erik-ritter--correct-stacked-bar-values-sum
branch
from
f61f7c1
to
6a136b0
Compare
|
I'll merge and see if it goes away. Travis passes which is more important. Netlify is nice to have |
* feat: 🎸 Improved QueryObject to handle more fields The commit is to ensure the feature parity between frontend and backend QueryOjbect * test: 💍 Added tests to improve the coverage
🐛 Bug Fix
Sets the bar values to the sum of only enabled series. This means that when you click on the legend to enable/disable series in multibar charts, the bar value will be the sum of only the visible bars. Unable to test right now because the build is broken, but will include screenshots once I can.
See sums changing when series are disabled:
to: @kristw