Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

feat: implement labelFlush behavior for continuous axes #117

Merged
merged 2 commits into from
May 31, 2019

Conversation

kristw
Copy link
Collaborator

@kristw kristw commented May 31, 2019

🏆 Enhancements

vega-lite 's axis has field labelFlush
image

  • Add this field to the encodeable grammar.
  • Implement the rendering engine to take advantage of this flag (only for x-axis). The benefits apply to line chart, box plot and scatter plot (all charts in preset-chart-xy).
    Top: default labelFlush = true, Bottom: labelFlush = 5 so it pushes both tick labels 5 pixels outwards from the center of the axis.
    image

@kristw kristw requested a review from a team as a code owner May 31, 2019 19:52
@kristw kristw merged commit 80b2227 into master May 31, 2019
@delete-merged-branch delete-merged-branch bot deleted the kristw--labelFlush branch May 31, 2019 19:56
nytai pushed a commit to preset-io/superset-ui-plugins that referenced this pull request Apr 27, 2020
nytai pushed a commit to preset-io/superset-ui-plugins that referenced this pull request Apr 27, 2020
…set#117)

* feat: add labelFlush to definition

* feat: implement flushing
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant