This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 77
fix: fixing tooltip for expanded area chart #134
Merged
etr2460
merged 1 commit into
apache-superset:master
from
michellethomas:fix_area_expanded_tooltip
Jul 5, 2019
Merged
fix: fixing tooltip for expanded area chart #134
etr2460
merged 1 commit into
apache-superset:master
from
michellethomas:fix_area_expanded_tooltip
Jul 5, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
=======================================
Coverage 19.87% 19.87%
=======================================
Files 8 8
Lines 161 161
Branches 10 10
=======================================
Hits 32 32
Misses 128 128
Partials 1 1 Continue to review full report at Codecov.
|
etr2460
reviewed
Jul 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this look when you click one of the items in the legend? In the current behavior, I think the tooltip has additional information when you unselect series from the chart
michellethomas
force-pushed
the
fix_area_expanded_tooltip
branch
from
July 2, 2019 16:55
1239924
to
cb651fa
Compare
etr2460
approved these changes
Jul 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
12 tasks
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
This PR added functionality for more data in the area chart rich tooltip, but those calculations don't make sense for the expanded chart. The expanded chart tooltip already shows % of total values and doesn't have a total line item.
generateAreaChartTooltipContent
shouldn't be called forexpand
stacked style.@graceguo-supercat @etr2460