This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
fix: responsive y-axis on stacked charts #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etr2460
force-pushed
the
erik-ritter--fix-stacked-charts
branch
from
3265724
to
9f42928
Compare
|
This also fixes an issue with charts with controls shown. Before: After: |
etr2460
force-pushed
the
erik-ritter--fix-stacked-charts
branch
from
9f42928
to
aae3367
Compare
etr2460
force-pushed
the
erik-ritter--fix-stacked-charts
branch
from
aae3367
to
ef3f562
Compare
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
=======================================
Coverage 19.87% 19.87%
=======================================
Files 8 8
Lines 161 161
Branches 10 10
=======================================
Hits 32 32
Misses 128 128
Partials 1 1Continue to review full report at Codecov.
|
|
Also also fixes responsiveness for line charts: Before: After: |
|
mind taking a look? |
khtruong
approved these changes
Jul 22, 2019
|
@kristw too if you wanna take a look |
12 tasks
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
* fix: callapi unit test * test: fix async calls * fix: remaining test * refactor: do not declare unused var
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
It looks like #45 introduced a new bug where when unselecting series on stacked charts the y-axis wouldn't be responsive to fix the chart size. I've tested this fix with series selected and unselected, no yAxisBounds and yAxisBounded, and everything seems to work as intended.
However, it seems like this logic has been changed a lot lately, so I might be missing edge cases. Let me know if I should test anything else!
No y axis bounds:
y axis bounds:
cc: @williaster @khtruong @michellethomas @graceguo-supercat