This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
fix: single y axis bounds #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etr2460
force-pushed
the
erik-ritter--fix-single-y-bounds
branch
from
38745e9
to
7e45ee6
Compare
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
=========================================
+ Coverage 19.87% 25.9% +6.02%
=========================================
Files 8 8
Lines 161 166 +5
Branches 10 10
=========================================
+ Hits 32 43 +11
+ Misses 128 122 -6
Partials 1 1
Continue to review full report at Codecov.
|
williaster
approved these changes
Jul 25, 2019
| chart.style() === 'stream' | ||
| ) { | ||
| // Because there are custom bounds, we need to override them back to the domain of the | ||
| // chart since this is a stream area chart |
| applyYAxisBounds(); | ||
|
|
||
| // Also reapply on each state change to account for enabled/disabled series | ||
| chart.dispatch.on('stateChange.applyYAxisBounds', () => { |
There was a problem hiding this comment.
can we remove the extra arrow func here?
chart.dispatch.on('stateChange.applyYAxisBounds', applyYAxisBounds)
etr2460
force-pushed
the
erik-ritter--fix-single-y-bounds
branch
from
7e45ee6
to
addb096
Compare
etr2460
force-pushed
the
erik-ritter--fix-single-y-bounds
branch
from
addb096
to
39e8a2e
Compare
|
tests added too |
|
🔥 |
This was referenced Jul 26, 2019
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
Further fixes to the custom y axis bounds for nvd3 charts. We were only respecting custom y axis bounds if they were both set; this allows the user to only set 1 custom y axis bound. The other one will be automatically calculated based on what type of chart this is and what the max/min data values are.
Note that this also special cases expanded area and stream area charts from having custom y axis bounds. These charts don't make much sense without the default bounds, so I've disabled them.
Screenshots:
bounds 0 - 3 billion
bounds 1 billion - null
ignore custom bounds
bar charts without bounds still work
reviewers: @khtruong @kristw @williaster @graceguo-supercat