This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
fix: disable lint error #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
approved these changes
Jul 25, 2019
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
…pache-superset#150) Updates the requirements on [whatwg-fetch](https://github.com/github/fetch) to permit the latest version. - [Release notes](https://github.com/github/fetch/releases) - [Commits](JakeChampion/fetch@v2.0.4...v3.0.0) Signed-off-by: dependabot[bot] <[email protected]>
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
It looks like this was failing because we the lint rule doesn't recognize the typescript exports in the file, so eslint thinks there's only one export and expects it to be a default export (see https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/prefer-default-export.md).
This fixes the build
@kristw