This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
fix: Line not hidden after legend selection #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
|
Deploy preview for superset-ui-plugins ready! Built with commit 0e5e9ab |
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
=======================================
Coverage 34.25% 34.25%
=======================================
Files 12 12
Lines 216 216
Branches 21 21
=======================================
Hits 74 74
Misses 132 132
Partials 10 10Continue to review full report at Codecov.
|
KKcorps
changed the title
|
Hi, Can anyone review this? |
|
Hi, can anyone look into this PR. The buggy behavior is not good at all. |
kristw
approved these changes
Sep 26, 2019
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
* fix: Line not hidden after legend selection * fix: lint issues
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
This PR fixes a bug in superset Line chart time series annotation. The bug is when you select an annotation time series and deselect it to show all the time series, the show markers and hide line properties are not honoured.