Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

fix: adjust world map colors #215

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

christophlingg
Copy link
Contributor

@christophlingg christophlingg commented Sep 30, 2019

🏆 Enhancements
as discussed in #53 , the world map colors have some issues

  • countries whose metric is close to the minimum will disappear from the map (white color fill on white background)
  • those countries' border also disappear as the border color is white as well
  • countries without any data show up in grey and thus
    • are more prominent than countries with low metrics
    • are not distinguishable with countries with data

this pull requests resolves these issues by

In theory this changes are an essential improvement over the current change. However, this is my first week with superset and it is not clear to me how to run examples locally and tune colors further. Any hint is more than welcome!

Bildschirmfoto 2019-09-30 um 14 22 28

@christophlingg christophlingg requested a review from a team as a code owner September 30, 2019 20:50
@ghost
Copy link

ghost commented Sep 30, 2019

There were the following issues with this Pull Request

  • Commit: 1b6e7d7
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@christophlingg christophlingg changed the title adjust world map colors fix: adjust world map colors Sep 30, 2019
@kristw
Copy link
Collaborator

kristw commented Oct 1, 2019

There seems to be a build issue (not from your PR) that prevents me from seeing the preview. May have to wait until that is resolved.

@christophlingg
Copy link
Contributor Author

all right, looking forward to see the preview

@christophlingg
Copy link
Contributor Author

@kristw is there anythingIi can help to fix the preview?

@kristw
Copy link
Collaborator

kristw commented Oct 8, 2019

@christophlingg Please feel free to open another PR to fix the build. I am out of bandwidth at the moment.

@christophlingg
Copy link
Contributor Author

@kristw all right, I will have a look. can you point me to the right places to not start from zero?

@kristw
Copy link
Collaborator

kristw commented Oct 17, 2019

Please rebase

@ghost
Copy link

ghost commented Oct 17, 2019

There were the following issues with this Pull Request

  • Commit: b15ea80
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #215 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #215   +/-   ##
=======================================
  Coverage   34.25%   34.25%           
=======================================
  Files          12       12           
  Lines         216      216           
  Branches       21       21           
=======================================
  Hits           74       74           
  Misses        132      132           
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36bae09...b15ea80. Read the comment docs.

@netlify
Copy link

netlify bot commented Oct 17, 2019

Deploy preview for superset-ui-plugins ready!

Built with commit b15ea80

https://deploy-preview-215--superset-ui-plugins.netlify.com

@christophlingg
Copy link
Contributor Author

Changes look pretty good to me: new vs old

new
old

@kristw

@kristw kristw merged commit f94a19b into apache-superset:master Oct 18, 2019
nytai pushed a commit to preset-io/superset-ui-plugins that referenced this pull request Apr 27, 2020
…pache-superset#215)

* feat: add Wrapper support and bounding box for dynamic width/height

* fix: unit tests

* fix: address comments and update unit tests

* docs: update storybook
nytai pushed a commit to preset-io/superset-ui-plugins that referenced this pull request Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants