This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
feat(plugin-chart-word-cloud): convert word cloud to use encodable #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for superset-ui-plugins ready! Built with commit 06b2e61 |
Codecov Report
@@ Coverage Diff @@
## master #258 +/- ##
=========================================
- Coverage 37.99% 36.9% -1.09%
=========================================
Files 12 12
Lines 229 233 +4
Branches 21 24 +3
=========================================
- Hits 87 86 -1
- Misses 132 135 +3
- Partials 10 12 +2
Continue to review full report at Codecov.
|
| export const ROTATION = { | ||
| flat: () => 0, | ||
| /* eslint-disable-next-line no-magic-numbers */ | ||
| random: () => Math.floor(Math.random() * 6 - 3) * 30, |
There was a problem hiding this comment.
Maybe leave a comment to explain that this calculates a random rotation between -90 and 90 degrees. I'm assuming the unit is degrees since square is * 90, but it would be helpful to read it explicitly when skimming the code.
kristw
changed the title
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
…pache-superset#258) * feat: convert word cloud to use encodable * fix: minor bugs * feat: bump dependencies * feat: use field * fix: defaultProps * fix: unit test * docs: update storybook * refactor: move files * docs: update storybook * fix: unit test * fix: address comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements
encodable.Basic
encodes color by word length
encodes font family by first letter
