fix: GH issue 8669 NVD3 tooltip overflow #278
Conversation
This reverts commit 44532e9.
|
Deploy preview for superset-ui-plugins ready! Built with commit 1c4a3bc |
| .nvtooltip tbody tr:not(:first-child) td:nth-child(2){ | ||
| word-break: break-word; | ||
| } | ||
| /* END tooltip styles */ |
There was a problem hiding this comment.
Committed. I wish people didn't object to using Husky to add pre-commit hooks running Prettier
There was a problem hiding this comment.
who objects to husky pre-commit hooks? I support that 👍
There was a problem hiding this comment.
on second thought, I'm not so sure. we've had these in other repos and the major downside of pre-commit hooks is that they can take longer and longer to run, especially as the repo grows.
I think you can setup your ide to auto-fix eslint (which calls prettier) changes on save.
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
======================================
Coverage 36.9% 36.9%
======================================
Files 12 12
Lines 233 233
Branches 24 24
======================================
Hits 86 86
Misses 135 135
Partials 12 12Continue to review full report at Codecov.
|
* fix: nvd3 tooltip overflow * fix: fix build * Revert "fix: fix build" This reverts commit 44532e9. * build: updating build-config package * fix: adds newline to css file
🐛 Bug Fix
This addresses Superset issue 8669:
apache/superset#8669
It also makes the headers bold, which hopefully looks better to folks.
Before:
After:
