This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
fix: TTestTable viz had className error, and broken CSS styling #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for superset-ui-plugins ready! Built with commit fe7b24b |
Codecov Report
@@ Coverage Diff @@
## master #286 +/- ##
======================================
Coverage 36.9% 36.9%
======================================
Files 12 12
Lines 233 233
Branches 24 24
======================================
Hits 86 86
Misses 135 135
Partials 12 12Continue to review full report at Codecov.
|
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
There was a method returning a boolean used as a className, causing two issues:
This easy peasy fix addresses both issues.
Before:
After:
