This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
fix: JS exception: Cannot read property 'dispatch' of undefined #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
graceguo-supercat
changed the title
graceguo-supercat
force-pushed
the
gg-FixAnnotationJSError
branch
from
97efe38
to
dc187fc
Compare
|
Deploy preview for superset-ui-plugins ready! Built with commit 97efe38 |
graceguo-supercat
force-pushed
the
gg-FixAnnotationJSError
branch
from
dc187fc
to
8617cda
Compare
|
Deploy preview for superset-ui-plugins ready! Built with commit dc187fc |
|
Deploy preview for superset-ui-plugins ready! Built with commit a11d757 |
graceguo-supercat
force-pushed
the
gg-FixAnnotationJSError
branch
from
8617cda
to
a11d757
Compare
Codecov Report
@@ Coverage Diff @@
## master #287 +/- ##
======================================
Coverage 36.9% 36.9%
======================================
Files 12 12
Lines 233 233
Branches 24 24
======================================
Hits 86 86
Misses 135 135
Partials 12 12Continue to review full report at Codecov.
|
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
…set#287) Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 24.9.1 to 25.1.1. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest) Signed-off-by: dependabot-preview[bot] <[email protected]>
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
Sometimes chart took longer time to render, and annotation layer is rendered before chart is ready. In this case, when the annotation layer tried to attach event handler for brush events, it will cause JS exception because chart.focus object is not created:
This error will make chart section blank, and cannot apply annotation at all.