This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
feat: add Canada to Country Maps #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
|
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
|
Would you mind rebasing on top of master? |
kristw
changed the title
Rebasing on top of master
….com/andy-clapson/superset-ui-plugins into andy--add-canada-to-country-map
Of course! Sorry about that. |
kristw
approved these changes
Apr 17, 2019
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
…superset#48) * migrate query code from incubator-superset * Getting tests to pass - Up build-config version to pick up a fix to eslint-typescript-parser - Remove usage of default exports in favor of named exports unless the export is the only thing being exported out of a module - Fixing up a few linting errors * - Remove DatasourceKey interface in favor of readonly id and type properties on the DatasourceKey class directly. - Adding tests for DatasourceKey.
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
…rset#48) travis build failed due to another issue, which is fixed in master. verified storybook and the new map is working correctly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements - adding Canada onto the ui plugins options.