feat: update data format returned from query api and add getGroupBys #72

kristw · 2019-04-24T00:00:33Z

🐛 Bug Fix

Update expected data format from /api/v1/query from

type Dataset<T extends string = string> = {
  keys: T[];	
  values: Partial<PlainObject<T>>[];	
}

to

type Dataset<T extends string = string> = Partial<PlainObject<T>>[];

Update corresponding code to no longer use dataset.keys.
Add functions for getting groupby from encoding.

netlify · 2019-04-24T00:08:35Z

Deploy preview for superset-ui-plugins ready!

Built with commit de8dcc2

https://deploy-preview-72--superset-ui-plugins.netlify.com

williaster

Nice! 😎👍

…pache-superset#72) * fix: update data format returned from query api * fix: format * fix: remove unnecessary type * fix: remove hack prior to typescript 3.4

kristw added 3 commits April 23, 2019 16:51

fix: update data format returned from query api

39894f1

fix: format

2afc2b0

fix: remove unnecessary type

8540595

kristw requested a review from a team as a code owner April 24, 2019 00:00

pull-request-size bot added the size/XL label Apr 24, 2019

kristw changed the title ~~fix: update data format returned from query api~~ feat: update data format returned from query api and add getGroupBys Apr 24, 2019

williaster approved these changes Apr 24, 2019

View reviewed changes

fix: remove hack prior to typescript 3.4

de8dcc2

kristw merged commit 3bbedb2 into master Apr 24, 2019

delete-merged-branch bot deleted the kristw--line-chart-data branch April 24, 2019 18:18

nytai pushed a commit to preset-io/superset-ui-plugins that referenced this pull request Apr 27, 2020

v0.8.0 (apache-superset#72)

b40189c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update data format returned from query api and add getGroupBys #72

feat: update data format returned from query api and add getGroupBys #72

kristw commented Apr 24, 2019

netlify bot commented Apr 24, 2019 •

edited

Loading

williaster left a comment

feat: update data format returned from query api and add getGroupBys #72

feat: update data format returned from query api and add getGroupBys #72

Conversation

kristw commented Apr 24, 2019

netlify bot commented Apr 24, 2019 • edited Loading

williaster left a comment

Choose a reason for hiding this comment

netlify bot commented Apr 24, 2019 •

edited

Loading