This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
feat: add sankey chart with loops #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for superset-ui-plugins ready! Built with commit a71cb72 |
|
@trebor CI is choking on a few lint errors in |
|
@xtinec i'm not sure what's up with the "Travis CI - Branch". seems like it's taking a long time, is that something that can be restarted? |
|
@kristw word is that you might have some insight into the failing steps in this pr. |
|
Trying to trigger ci to rebuild correctly so i can review the output |
kristw
reviewed
Apr 30, 2019
packages/superset-ui-legacy-plugin-chart-sankey-loop/src/SankeyLoop.js
Outdated
Show resolved
Hide resolved
kristw
reviewed
Apr 30, 2019
packages/superset-ui-legacy-plugin-chart-sankey-loop/package.json
Outdated
Show resolved
Hide resolved
kristw
reviewed
Apr 30, 2019
packages/superset-ui-legacy-plugin-chart-sankey-loop/package.json
Outdated
Show resolved
Hide resolved
kristw
reviewed
Apr 30, 2019
packages/superset-ui-legacy-plugin-chart-sankey-loop/src/SankeyLoop.js
Outdated
Show resolved
Hide resolved
kristw
reviewed
Apr 30, 2019
packages/superset-ui-legacy-plugin-chart-sankey-loop/src/SankeyLoop.js
Outdated
Show resolved
Hide resolved
|
@kristw it looks like all the tests are passing, but the build is hung again. how do i get this moving? |
|
going to try closing, waiting a bit and reopening again. :\ |
|
merging as the |
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
* feat(chart): add basic working look sankey chart * fix(doc): update readme and remove dead code * fix(clean): clean up both style and code * fix(reorg): reogranize for clarity * fix(path): remove dev path to chart * fix(lint): remove lint * fix(pr): fixes for PR * fix(path): fix dev path * fix(lint): remove unused
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements