Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

fix: disable lazy import for line chart and box plot #82

Merged
merged 2 commits into from
May 8, 2019

Conversation

kristw
Copy link
Collaborator

@kristw kristw commented May 7, 2019

🏠 Internal

  • Disable lazy import temporarily due to problem with downstream application.
  • Also fix broken build

@kristw kristw requested a review from a team as a code owner May 7, 2019 19:20
Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry to go backward on this :( LGTM if the mock loader doesn't work 👍

@kristw
Copy link
Collaborator Author

kristw commented May 7, 2019

build broken due to changes in eslint react/sort-comp changes how it thinks things should be ordered -*-. just pushed a fix.

@netlify
Copy link

netlify bot commented May 7, 2019

Deploy preview for superset-ui-plugins ready!

Built with commit 1bbdfef

https://deploy-preview-82--superset-ui-plugins.netlify.com

@netlify
Copy link

netlify bot commented May 7, 2019

Deploy preview for superset-ui-plugins ready!

Built with commit dee5d61

https://deploy-preview-82--superset-ui-plugins.netlify.com

@kristw kristw merged commit 5161e5e into master May 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the kristw--diligent-import branch May 8, 2019 02:19
nytai pushed a commit to preset-io/superset-ui-plugins that referenced this pull request Apr 27, 2020
nytai pushed a commit to preset-io/superset-ui-plugins that referenced this pull request Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants