Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Test_find_not_should_ignore_path is flaky #10988

Closed
potiuk opened this issue Sep 17, 2020 · 0 comments · Fixed by #11993
Closed

The Test_find_not_should_ignore_path is flaky #10988

potiuk opened this issue Sep 17, 2020 · 0 comments · Fixed by #11993
Labels
area:Scheduler including HA (high availability) scheduler good first issue kind:bug This is a clearly a bug

Comments

@potiuk
Copy link
Member

potiuk commented Sep 17, 2020

It seems that the test_find_not_should_ignore_path test has some dependency on side-effects from other tests.

For example it failed here:

https://github.com/apache/airflow/pull/10983/checks?check_run_id=1127304894#step:6:1043

>       self.assertEqual(detected_files, should_not_ignore_files)
E       AssertionError: Items in the second set but not the first:
E       'test_load.py'
E       'test_load_sub1.py'

And re-running it in a clean system works just fine in the same combination of python/db.

What you expected to happen:

The test should clean up /restore everything it needs before running or a test that makes side-effects is found and fixed.

For now I am moving the test to "heisentests with appropriate note.".
@potiuk potiuk added kind:bug This is a clearly a bug good first issue labels Sep 17, 2020
This was referenced Sep 17, 2020
Merged
Merged
potiuk added a commit to PolideaInternal/airflow that referenced this issue Sep 17, 2020
@potiuk
The test_find_not_should_ignore_path is now in heisentests
f62d7f9 
It seems that the test_find_not_should_ignore_path test has some
dependency on side-effects from other tests.

See apache#10988 - we are moving this test to heisentests until we
solve the issue.
potiuk added a commit that referenced this issue Sep 17, 2020
@potiuk
The test_find_not_should_ignore_path is now in heisentests (#10989)
82a9477 
It seems that the test_find_not_should_ignore_path test has some
dependency on side-effects from other tests.

See #10988 - we are moving this test to heisentests until we
solve the issue.
@mik-laj mik-laj added the area:Scheduler including HA (high availability) scheduler label Sep 30, 2020
@megaserg megaserg mentioned this issue Oct 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:Scheduler including HA (high availability) scheduler good first issue kind:bug This is a clearly a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix heisentest by ignoring the basepath megaserg/airflow
2 participants
@potiuk @mik-laj