Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing timer metric dag.loading-duration.<dag_file> in documentation #11341

Closed
wolfier opened this issue Oct 7, 2020 · 3 comments
Closed

Missing timer metric dag.loading-duration.<dag_file> in documentation #11341

wolfier opened this issue Oct 7, 2020 · 3 comments
Assignees
Labels
area:monitoring kind:bug This is a clearly a bug

Comments

@wolfier
Copy link
Contributor

wolfier commented Oct 7, 2020

Apache Airflow version: doc on version 1.10.6+

In 1.10.5 metrics documentation, there is an entry for dag.loading-duration.<dag_id>.

In 1.10.6 metrics documentation, the entry disappeared.

The format has also change from dag.loading-duration.<dag_file> to dag.loading-duration.<dag_id> starting from 1.10.4 according to this JIRA ticket and PR.

@wolfier wolfier added the kind:bug This is a clearly a bug label Oct 7, 2020
@kaxil
Copy link
Member

kaxil commented Oct 8, 2020

Thanks, will check

@kaxil kaxil self-assigned this Oct 8, 2020
@kaxil
Copy link
Member

kaxil commented Oct 8, 2020

So the issue was although the docs were updated in 1.10.6 the code wasn't. But the metric dag.loading-duration.<dag_id> was emitted (also in Airflow 1.10.12)

From Airflow 1.10.13 this metric will be changed to dag_processing.loading-duration.<dag_file> (#5890 has been cherry-picked)

@kaxil
Copy link
Member

kaxil commented Nov 18, 2020

(#5890 has been cherry-picked)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:monitoring kind:bug This is a clearly a bug
Projects
None yet
Development

No branches or pull requests

3 participants