Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SambaHook using old unmaintained library #14054

Closed
HaloKo4 opened this issue Feb 3, 2021 · 11 comments · Fixed by #17273
Closed

SambaHook using old unmaintained library #14054

HaloKo4 opened this issue Feb 3, 2021 · 11 comments · Fixed by #17273

Comments

@HaloKo4
Copy link

HaloKo4 commented Feb 3, 2021

Description
The SambaHook currently using pysmbclient this library hasn't been updated since 2017 https://pypi.org/project/PySmbClient/

I think worth moving to https://pypi.org/project/smbprotocol/ which newer and maintained.

@Rishabhraghwendra18
Copy link

Hi...May I work on this ?

@potiuk
Copy link
Member

potiuk commented Feb 4, 2021

Sure! I assigned you :)

@Rishabhraghwendra18
Copy link

@potiuk thanks man ;)

@HaloKo4
Copy link
Author

HaloKo4 commented Feb 15, 2021

thanks @Rishabhraghwendra18 looking forward to this!

@Rishabhraghwendra18
Copy link

I am really sorry guys. I am not able to setup the development on my machine . And I am also having university exams within this month .So I am not able to contribute 😞. I am unassingning myself.

@Rishabhraghwendra18 Rishabhraghwendra18 removed their assignment Feb 28, 2021
@potiuk
Copy link
Member

potiuk commented Feb 28, 2021

I am really sorry guys. I am not able to setup the development on my machine . And I am also having university exams within this month .So I am not able to contribute . I am unassingning myself.

Too bad. Next time maybe,

@Rishabhraghwendra18
Copy link

ya..sure

@marcosmarxm
Copy link
Contributor

@potiuk can I take this one instead? I'm finishing the Airbyte provider so right now is easier to do this modification :D

@ashb
Copy link
Member

ashb commented Mar 2, 2021

@marcosmarxm Sure, all yours!

@uranusjr
Copy link
Member

uranusjr commented Jun 3, 2021

It seems like pysmb is another choice. Not sure whether it or smbprotocol is better/more suitable.

@malthe
Copy link
Contributor

malthe commented Jul 19, 2021

@uranusjr one deficiency in pysmb that I came upon was lack of Samba 2.1+ support, see miketeo/pysmb#95 (comment).

I might be able to find time to dig into this – adding "credits support". If there's a reference implementation in Go, then it shouldn't be too hard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants