Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create get_partition, create_partition methods in AWS Glue Catalog Hook #19272

Closed
2 tasks done
harsh2911 opened this issue Oct 28, 2021 · 6 comments · Fixed by #23857
Closed
2 tasks done

Create get_partition, create_partition methods in AWS Glue Catalog Hook #19272

harsh2911 opened this issue Oct 28, 2021 · 6 comments · Fixed by #23857
Assignees
Labels
good first issue kind:feature Feature Requests provider:amazon-aws AWS/Amazon - related issues

Comments

@harsh2911
Copy link

Description

Current AWS Glue Catalog Hook does not have all the methods.
If possible, we can add get_partition and create_partition methods in existing Glue Catalog Hook.

Use case/motivation

I do work in Amazon.com. Our team is using Airflow to orchestrate Data Builds for our services.
In process of data builds, we need to create new Glue partitions for generated data and also retrieve particular Glue partition. Existing Glue Catalog Hook does not contain all the available methods.

Related issues

I was not able to find any related existing issues or feature request.

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@harsh2911 harsh2911 added the kind:feature Feature Requests label Oct 28, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 28, 2021

Thanks for opening your first issue here! Be sure to follow the issue template!

@mik-laj mik-laj added the provider:amazon-aws AWS/Amazon - related issues label Oct 28, 2021
@potiuk
Copy link
Member

potiuk commented Oct 28, 2021

Feel free !

@eladkal
Copy link
Contributor

eladkal commented Dec 20, 2021

@harsh2911 are you still working on this?

@harsh2911
Copy link
Author

@eladkal Yes, I will be working on this in next 2 weeks.

@victorphoenix3
Copy link
Contributor

Hi @eladkal, I am new to the community and would like to work on this feature request. I looked at the codebase and get_partition method already exists. Should I put up a PR for create_partition and are there any other methods that should be added ?

@vincbeck
Copy link
Contributor

vincbeck commented May 18, 2022

Welcome to the community :) Unless I am mistaken get_partition does not exist, only get_partitions does. Sure! Feel free to create a PR for these 2 methods and I'll be more than happy to review it.

If you think other methods are needed, feel free to implement them too but implementing these 2 methods is already great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue kind:feature Feature Requests provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants