Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align TriggerDagRunOperator with logical date terminology #26916

Closed
eladkal opened this issue Oct 6, 2022 · 4 comments · Fixed by #39285
Closed

Align TriggerDagRunOperator with logical date terminology #26916

eladkal opened this issue Oct 6, 2022 · 4 comments · Fixed by #39285
Labels
affected_version:2.4 Issues Reported for 2.4 area:core-operators Operators, Sensors and hooks within Core Airflow good first issue kind:bug This is a clearly a bug

Comments

@eladkal
Copy link
Contributor

eladkal commented Oct 6, 2022

Spawn of #19264

By the way, since execution_date has been renamed to logical_date, but TriggerDagRunOperator still uses this nomenclature, shouldn't this be changed? Like so:

  • rename the execution_date parameter to logical_date
  • using the execution_date parameter in this class would call logical_date for backward compatibility, after raising a deprecation warning

If this makes sense, I can create a new issue about it.

Originally posted by @augusto-herrmann in #19264 (comment)

@eladkal eladkal added kind:bug This is a clearly a bug good first issue area:core-operators Operators, Sensors and hooks within Core Airflow affected_version:2.4 Issues Reported for 2.4 labels Oct 6, 2022
@frankcash
Copy link
Contributor

frankcash commented Oct 6, 2022

@eladkal I wonder if execution_date is still "valid" due to the fact that the API call https://github.com/apache/airflow/blob/main/airflow/operators/trigger_dagrun.py#L136-L142 takes execution_date as a parameter. https://github.com/apache/airflow/blob/main/airflow/api/common/trigger_dag.py#L31-L38

@eladkal
Copy link
Contributor Author

eladkal commented Oct 6, 2022

We may need to allign other parts of the code

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

This issue has been automatically marked as stale because it has been open for 365 days without any activity. There has been several Airflow releases since last activity on this issue. Kindly asking to recheck the report against latest Airflow version and let us know if the issue is reproducible. The issue will be closed in next 30 days if no further activity occurs from the issue author.

@augusto-herrmann
Copy link
Contributor

augusto-herrmann commented Oct 16, 2023

I have just checked the documentation for Airflow 2.7.2 and the TriggerDagRunOperator still has a parameter named execution_date and does not have a parameter named logical_date.

So the issue still persists in current Airflow.

PR #26925 was supposed to fix this, but got closed by the author without merging.

@github-actions github-actions bot added needs-triage label for new issues that we didn't triage yet and removed Stale Bug Report labels Oct 17, 2023
@RNHTTR RNHTTR removed the needs-triage label for new issues that we didn't triage yet label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected_version:2.4 Issues Reported for 2.4 area:core-operators Operators, Sensors and hooks within Core Airflow good first issue kind:bug This is a clearly a bug
Projects
None yet
4 participants