Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --executor flag works for breeze start-airflow command #28412

Closed
1 task done
potiuk opened this issue Dec 16, 2022 · 12 comments
Closed
1 task done

Make --executor flag works for breeze start-airflow command #28412

potiuk opened this issue Dec 16, 2022 · 12 comments
Assignees
Labels
area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code area:dev-tools good first issue kind:meta High-level information important to the community

Comments

@potiuk
Copy link
Member

potiuk commented Dec 16, 2022

Body

Currently breeze start-airflow command only uses LocalExecutor and starts scheduler, triggerer and webserver. However it would be nice if it accepts --executor flag that could accept other executors. This would be much nicer to test some scenarios - mostly with regards to Celery executor.

Such a flag could:

  • enable --celery integraiton (With rabbitmq and redis)
  • also start worker (optionallly more than one)
  • also start flower

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@potiuk potiuk added kind:meta High-level information important to the community area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code area:dev-tools good first issue labels Dec 16, 2022
@ibrahimdurmus
Copy link

i can pick this up, if no one is looking at it. thanks

@victorjourne
Copy link

Hi @ibrahimdurmus, have you started working on it?

@ibrahimdurmus
Copy link

yes i am working on it thanks @victorjourne

@pierrejeambrun
Copy link
Member

Looking forward to this one. I remember a couple of times where this would have been really handy 😀

@utkarsharma2
Copy link
Contributor

@potiuk @pierrejeambrun Can you please assign this ticket to me?

@eladkal
Copy link
Contributor

eladkal commented Jul 6, 2023

Did #30644 solve this issue?

@utkarsharma2
Copy link
Contributor

utkarsharma2 commented Jul 6, 2023

Did #30644 solve this issue?

@eladkal This pr adds support for celeryExecutor and localExecutor. We still need support for the remaining executors. I was planning to work on the remaining tasks shortly.

@eladkal
Copy link
Contributor

eladkal commented Jun 2, 2024

@utkarsharma2 are you still working on this issue?

@potiuk
Copy link
Member Author

potiuk commented Jun 2, 2024

It's done actually :)

@potiuk potiuk closed this as completed Jun 2, 2024
@potiuk
Copy link
Member Author

potiuk commented Jun 2, 2024

the K8S executor is quite a bit more complex, and we actually have breeze k8s suite of commands that you can deploy Airflow with k8s - including, k8s, Celery and Local executor - We need a k8s instance to run k8s executor, It would be nice to support k8s executor from the docker-compose's breeze but it is quite complex. I'd rather get a better description on how to use things like https://www.getambassador.io/docs/telepresence/latest/quick-start for the k8s suite of commands and possibly add some integration there.

@potiuk
Copy link
Member Author

potiuk commented Jun 2, 2024

I created #40005

@utkarsharma2
Copy link
Contributor

@utkarsharma2 are you still working on this issue?

I wanted to work on it, but there was a learning curve for me. If no one picks up #40005 hopefully, I can resume working on it in the next week or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code area:dev-tools good first issue kind:meta High-level information important to the community
Projects
None yet
Development

No branches or pull requests

6 participants