Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task ID copy button copying wrong ID #34846

Closed
1 of 2 tasks
ByPort opened this issue Oct 10, 2023 · 4 comments · Fixed by #34904
Closed
1 of 2 tasks

Task ID copy button copying wrong ID #34846

ByPort opened this issue Oct 10, 2023 · 4 comments · Fixed by #34904
Assignees
Labels
affected_version:2.7 Issues Reported for 2.7 area:UI Related to UI/UX. For Frontend Developers. good first issue kind:bug This is a clearly a bug

Comments

@ByPort
Copy link
Contributor

ByPort commented Oct 10, 2023

Apache Airflow version

2.7.1

What happened

The Task ID copy button in Grid View copies the first Task ID copied until the page refresh

What you think should happen instead

The corresponding Task ID should be copied

How to reproduce

  1. Go to Grid view and open any task
  2. Click the copy button in front of the Task ID
  3. The ID in the clipboard is correct
  4. Open another task
  5. (optional) Copy any stuff to reset the clipboard
  6. Click the copy button again
  7. The ID in the clipboard is the ID from Step 2

In any other task, the first Task ID (from Step 2) will be copied until the page is refreshed

Operating System

Mac OS (ARM)

Versions of Apache Airflow Providers

No response

Deployment

Docker-Compose

Deployment details

No response

Anything else

It occurs every time in the latest Chrome browser

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@ByPort ByPort added area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Oct 10, 2023
@Taragolis Taragolis added area:UI Related to UI/UX. For Frontend Developers. and removed needs-triage label for new issues that we didn't triage yet area:core labels Oct 10, 2023
@Adaverse
Copy link
Contributor

Nice catch. The problem is that the component responsible for copying won't re-render (which is the expectation looking at the current code). Hence we need to explicitly set the value that needs to be copied when it changes. Will raise a PR.

@AchimGaedkeLynker
Copy link
Contributor

Any chance resolving this soon?

@potiuk
Copy link
Member

potiuk commented Dec 20, 2023

Any chance resolving this soon?

There is a PR linked it seems - commenting there, helping with reviews, cherry-picking and testing and confirming that it works is the best way you can help with getting it out faster (In case what you are really asking about is "how can I help to speed it up?") @AchimGaedkeLynker

@AchimGaedkeLynker
Copy link
Contributor

Will try my best on my weakest domain of software engineering: JS in web browsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected_version:2.7 Issues Reported for 2.7 area:UI Related to UI/UX. For Frontend Developers. good first issue kind:bug This is a clearly a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants