Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bold and increase font-size of graph task headers #36557

Closed
2 tasks done
NilsJPWerner opened this issue Jan 3, 2024 · 6 comments · Fixed by #37207
Closed
2 tasks done

Bold and increase font-size of graph task headers #36557

NilsJPWerner opened this issue Jan 3, 2024 · 6 comments · Fixed by #37207
Assignees
Labels
area:UI Related to UI/UX. For Frontend Developers. type:improvement Changelog: Improvements

Comments

@NilsJPWerner
Copy link

Description

I think bolding and increasing the fontsize of task headers would improve legibility. Here is a comparison:

Before:

After:

This was from just adding font-weight: bold and font-size: 14px to the header css, and increasing the height of the task by a few pixels.

Some other suggestions are to make the the border a bit wider and drop the task status from the contents since the border now makes it redundant. It could be replaced with duration or nothing at all.

Use case/motivation

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@NilsJPWerner NilsJPWerner added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels Jan 3, 2024
@jscheffl jscheffl added type:improvement Changelog: Improvements area:UI Related to UI/UX. For Frontend Developers. and removed kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels Jan 3, 2024
@jscheffl
Copy link
Contributor

jscheffl commented Jan 3, 2024

Thanks for the proposal. Peronally I'd prefer to keep a consistent font size (meaning not too many different font sizes on the UI) but making bold text and other proposals looks good to me (but I am just one person - other opinions welcome).

I assigned you the issue, feel free to raise a PR.

@NilsJPWerner
Copy link
Author

@bbovenzi do you have thoughts?

@aadeshmodak13
Copy link

We have to go to airflow/www/static/css/graph.css Am I right?? I'm new to open source.

@bbovenzi
Copy link
Contributor

We got rid of most of graph.css. It's all in https://github.com/apache/airflow/tree/main/airflow/www/static/js/dag/details/graph now.

We can definitely make the name bigger. One idea I was toying with was also to hide details and only show the status color and task name when you zoom out.

@NilsJPWerner
Copy link
Author

That's a good idea! I was thinking that running tasks could dynamically display their current run time as well. You could also have some sort of progress indicator that compares current run time to average previous run times. That may be a bit involved though.

@bbovenzi
Copy link
Contributor

Yes it would be fun to be able to display more useful info like that while also having a simpler view too.

Rough WIP:
Screenshot 2024-01-25 at 4 34 21 PM

Screenshot 2024-01-25 at 4 34 27 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants