Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google providers 10.19.0 bigquery operators directly depends on openlineage package #40043

Closed
2 tasks done
ahidalgob opened this issue Jun 4, 2024 · 1 comment · Fixed by #40062
Closed
2 tasks done

google providers 10.19.0 bigquery operators directly depends on openlineage package #40043

ahidalgob opened this issue Jun 4, 2024 · 1 comment · Fixed by #40062
Labels
area:dependencies Issues related to dependencies problems area:providers kind:bug This is a clearly a bug provider:google Google (including GCP) related issues

Comments

@ahidalgob
Copy link
Contributor

ahidalgob commented Jun 4, 2024 •
edited
Loading

Apache Airflow Provider(s)

google

Versions of Apache Airflow Providers

10.19.0

Apache Airflow version

2.7.0+

Operating System

linux

Deployment

Google Cloud Composer

Deployment details

No response

What happened

pull/39614 refactored _BigQueryOpenLineageMixin and now bigquery operators directly import from openlineage package, even when Open Lineage provider is not installed, so importing any BigQuery operator fails with ImportError

I can create the PR to fix it

What you think should happen instead

Imports should happen lazily, only when get_openlineage_facets_on_complete is called.

How to reproduce

Install Google Providers package 10.19.0 without openlineage package installed

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@ahidalgob ahidalgob added area:providers kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Jun 4, 2024
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Jun 4, 2024

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

@shahar1 shahar1 added provider:google Google (including GCP) related issues area:dependencies Issues related to dependencies problems and removed needs-triage label for new issues that we didn't triage yet labels Jun 4, 2024
@ahidalgob ahidalgob mentioned this issue Jun 5, 2024
Merged
@ahidalgob ahidalgob changed the title google providers 10.19.0 directly depends on openlineage package google providers 10.19.0 bigquery operators directly depends on openlineage package Jun 6, 2024
@eladkal eladkal mentioned this issue Jun 22, 2024
Closed
96 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:dependencies Issues related to dependencies problems area:providers kind:bug This is a clearly a bug provider:google Google (including GCP) related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

google: move bigquery openlineage imports inside methods ahidalgob/airflow
2 participants
@ahidalgob @shahar1