Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SnowflakeSqlApiOperator's Snowflake Legacy Url Authentication Issue #40885

Closed
1 of 2 tasks
shubham-arora-18 opened this issue Jul 19, 2024 · 5 comments
Closed
1 of 2 tasks
Labels
area:providers kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet pending-response provider:snowflake Issues related to Snowflake provider

Comments

@shubham-arora-18
Copy link

shubham-arora-18 commented Jul 19, 2024

Apache Airflow version

Other Airflow 2 version (please specify below)

If "Other Airflow 2 version" selected, which one?

2.5.1

What happened?

I have been facing an issue with GCP airflow.

  • Version of composer: composer-2.3.3
  • Version of airflow: airflow-2.5.1
  • Version of apache-airflow-providers-snowflake package: 5.1.2

Issue is:

  1. The normal SnowflakeOperator(airflow.providers.snowflake.operators.snowflake.SnowflakeOperator) internally uses correct url for snowflake authentication (https://<orgname>-<account_name>.[snowflakecomputing.com](http://snowflakecomputing.com/).
  2. But SnowflakeSqlApiOperator (airflow.providers.snowflake.operators.snowflake.SnowflakeSqlApiOperator) uses legacy url for snowflake authentication(https://<accountlocator>.<region>.<cloud>.[snowflakecomputing.com](http://snowflakecomputing.com/).
  3. The use of legacy url is discouraged and support for the same will end soon, we confirmed this from snowflake.
  4. I looked at the change log between 5.1.2 version to the latest version(5.6.0) but no log suggests this has been taken care of.

Related Links:
Apache Airflow Snowflake package documentation: Link
Snowflake documentation for authentication: Link

What you think should happen instead?

The SnowflakeSqlApiOperator should use the same url for snowflake authentication as the SnowflakeOperator.

How to reproduce

Try running a query with SnowflakeSqlApiOperator on your snowflake instance.

Operating System

mac

Versions of Apache Airflow Providers

No response

Deployment

Google Cloud Composer

Deployment details

No response

Anything else?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@shubham-arora-18 shubham-arora-18 added area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Jul 19, 2024
Copy link

boring-cyborg bot commented Jul 19, 2024

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

@dosubot dosubot bot added the provider:snowflake Issues related to Snowflake provider label Jul 19, 2024
@shahar1
Copy link
Contributor

shahar1 commented Jul 19, 2024

The Cloud Composer, AIrflow and snowflake versions seem outdated - have you tried upgrading each to the latest?

@shubham-arora-18
Copy link
Author

The Cloud Composer, AIrflow and snowflake versions seem outdated - have you tried upgrading each to the latest?

Updating composer is a taxing task. No point in upgrading the composer unless the issue has been resolved in the latest apache snowflake library. I don't see any such change in the changelog.

Please correct me if wrong.

@shahar1
Copy link
Contributor

shahar1 commented Jul 22, 2024

The Cloud Composer, AIrflow and snowflake versions seem outdated - have you tried upgrading each to the latest?

Updating composer is a taxing task. No point in upgrading the composer unless the issue has been resolved in the latest apache snowflake library. I don't see any such change in the changelog.

Please correct me if wrong.

Could you please take a look at #37922 and check if it should resolve the issue? (it exists in versions 5.4.0+ of the Snowflake provider)

@shubham-arora-18
Copy link
Author

Yes, I just checked it and it is fixed. Closing the issue, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet pending-response provider:snowflake Issues related to Snowflake provider
Projects
None yet
Development

No branches or pull requests

2 participants