Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Endpoints - Read-only - Variable #8133

Closed
mik-laj opened this issue Apr 4, 2020 · 4 comments · Fixed by #9273
Closed

API Endpoints - Read-only - Variable #8133

mik-laj opened this issue Apr 4, 2020 · 4 comments · Fixed by #9273
Assignees
Labels
area:API Airflow's REST/HTTP API good first issue kind:feature Feature Requests

Comments

@mik-laj
Copy link
Member

mik-laj commented Apr 4, 2020

Description

Hello

We need to create several endpoints that perform basic read-only operations on Variable . We need the following endpoints:

  • GET /variables
  • GET /variables/{variable_key}

Detailed information is available in the issue:
#8118

Use case / motivation
N/A

Related Issues
N/A

@mik-laj mik-laj added the kind:feature Feature Requests label Apr 4, 2020
@mik-laj mik-laj changed the title API Endpoint - CRUD - Variable API Endpoints - CRUD - Variable Apr 4, 2020
@mik-laj mik-laj added the area:API Airflow's REST/HTTP API label Apr 4, 2020
@mik-laj mik-laj mentioned this issue Apr 4, 2020
@mik-laj mik-laj changed the title API Endpoints - CRUD - Variable API Endpoints - Read-only - Variable Jun 2, 2020
@mik-laj
Copy link
Member Author

mik-laj commented Jun 2, 2020

@houqp Do you want to work on it?
We are ready. You can start working from this file
https://github.com/apache/airflow/blob/master/airflow/api_connexion/endpoints/variable_endpoint.py

For now, we focus only on read-only operations, but others will also be implemented as the next step.

@houqp
Copy link
Member

houqp commented Jun 2, 2020

@mik-laj yes, I can take a stab at it this week. do you mind if I implement write endpoints as well or do you prefer me to only fill out the read endpoints?

@mik-laj
Copy link
Member Author

mik-laj commented Jun 2, 2020

A single PR can close multiple tickets. I divided the variable endpoints because I want to involve many new people in these tasks. When the ticket is small it is easier to finish it.
Here is a ticket about CRUD operation for Variable:
#9115
Does this sound good to you?

@houqp
Copy link
Member

houqp commented Jun 2, 2020

@mik-laj looks good to me!

@mik-laj mik-laj linked a pull request Jun 14, 2020 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API good first issue kind:feature Feature Requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants