Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DbApiHook: add chunksize to get_pandas_df parameters #8468

Closed
wittfabian opened this issue Apr 20, 2020 · 4 comments · Fixed by #9730
Closed

DbApiHook: add chunksize to get_pandas_df parameters #8468

wittfabian opened this issue Apr 20, 2020 · 4 comments · Fixed by #9730
Labels
kind:feature Feature Requests

Comments

@wittfabian
Copy link
Contributor

Description

The method "get_pandas_df" should be extended by the parameter "chunksize".

Use case / motivation

For the case that very large amounts of data are read, the "chunksize" is a good way to reduce the size of individual queries.

Links

return psql.read_sql(sql, con=conn, params=parameters)

https://github.com/pandas-dev/pandas/blob/0.25.x/pandas/io/sql.py#L344

@imorales-mosaico
Copy link

There are a problem with the chunksize, because the get_pandas_df close the connection in the first call of the iterator[DataFrame] returned

@carmoreno1
Copy link

There are a problem with the chunksize, because the get_pandas_df close the connection in the first call of the iterator[DataFrame] returned

Hi @imorales-mosaico is there a workaround about chunksize using Airflow?

@potiuk
Copy link
Member

potiuk commented Mar 21, 2022

Please @imorales-mosaico - open a new Feature/Bug request with a bit better description, rather than commenting on a closed ticket (you can add Relates to: #8464 in the description).

@potiuk
Copy link
Member

potiuk commented Mar 21, 2022

(Or Ideally submit a PR fixing the problem immediately - if there is a problem).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feature Feature Requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants