Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: supporting key-auth plugin to get key from query string #2092

Closed
liuxiran opened this issue Aug 26, 2021 · 2 comments · Fixed by #2261
Closed

Feature request: supporting key-auth plugin to get key from query string #2092

liuxiran opened this issue Aug 26, 2021 · 2 comments · Fixed by #2261
Labels
frontend good first issue Good for newcomers
Milestone
2.9.1

Comments

@liuxiran
Copy link
Contributor

Feature request

Please describe your feature

refer to apache/apisix#4490, currently we can configure key-auth plugin in Route and Service with header or query properties, so we should remove the tip in the key-auth configure page when create/configure Route 、 Service and global plugin

image
@liuxiran liuxiran modified the milestones: 2.8, 2.9 Aug 26, 2021
@github-actions
Copy link

github-actions bot commented Nov 6, 2021

This issue has been marked as stale due to 30 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 6, 2021
@bzp2010 bzp2010 added good first issue Good for newcomers and removed stale labels Nov 8, 2021
@zaunist
Copy link
Contributor

zaunist commented Dec 21, 2021

Hi, @liuxiran . IMO, we just remove the tips ?

@zaunist zaunist mentioned this issue Dec 22, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend good first issue Good for newcomers
Projects
None yet
Milestone
2.9.1
Development

Successfully merging a pull request may close this issue.

feat(route): remove key-auth plugin tip
3 participants
@liuxiran @bzp2010 @zaunist