Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disable ssl verify for etcd connection #3283

Closed
spacewander opened this issue Jan 14, 2021 · 9 comments · Fixed by #3415
Closed

Support disable ssl verify for etcd connection #3283

spacewander opened this issue Jan 14, 2021 · 9 comments · Fixed by #3415
Assignees
Milestone

Comments

@spacewander
Copy link
Member

Currently when people want to connect etcd cluster via TLS, there is no way to disable SSL verify.

We need to solve it in two aspects:

  1. allow disabling SSL verify in apisix/cli with luasocket
  2. allow disabling SSL verify in lua-resty-etcd.
@spacewander
Copy link
Member Author

This feature will solve #3225

@spacewander
Copy link
Member Author

@starsz

@starsz
Copy link
Contributor

starsz commented Jan 14, 2021

Got it. Please assign it to me.

@tokers
Copy link
Contributor

tokers commented Jan 15, 2021

https://github.com/api7/lua-resty-etcd/blob/master/lib/resty/etcd/v3.lua#L113 @spacewander lua-resty-etcd already supports to verify SSL or not.

@spacewander
Copy link
Member Author

But we don't pass the option to it.

@starsz
Copy link
Contributor

starsz commented Jan 15, 2021

Should lua-resty-etcd support blocking requests by using luasocket?
Then we can use lua-resty-etcd in apisix/cli.

@spacewander
Copy link
Member Author

@starsz
It would be great. We can do it in a separate PR.

@tokers
Copy link
Contributor

tokers commented Jan 15, 2021

But we don't pass the option to it.

You mean APISIX or others?
https://github.com/apache/apisix/blob/master/apisix/core/config_etcd.lua#L502

@spacewander
Copy link
Member Author

Sorry, it is my mistake...

@spacewander spacewander added this to the 2.3 milestone Jan 18, 2021
@spacewander spacewander added bug Something isn't working and removed bug Something isn't working labels Jan 20, 2021
@spacewander spacewander assigned tokers and unassigned starsz Jan 25, 2021
@tokers tokers linked a pull request Jan 25, 2021 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants