Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend chaitin-waf plugin functionalities #9945

Open
lingsamuel opened this issue Aug 2, 2023 · 2 comments
Open

feat: extend chaitin-waf plugin functionalities #9945

lingsamuel opened this issue Aug 2, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@lingsamuel
Copy link
Member

There are some todos need to be done in chaitin-waf plugin.

  1. add a configuration for "mode" attribute
  2. add a configuration to enable/disable the real client IP
  3. use lrucache to cache the var expression result (traffic-split plugin also need this)
@lingsamuel lingsamuel added the enhancement New feature or request label Aug 2, 2023
@moonming moonming added help wanted Extra attention is needed good first issue Good for newcomers labels Aug 2, 2023
@PalAditya
Copy link

Hi, I'd like to work on this if possible. Adding a few questions as well to make sure my understanding is correct:

@sreeram-venkitesh
Copy link

I have opened #11705 to add the cache. @lingsamuel @moonming Please review the PR and let me know if I'm on the right path. I'd love to work on the rest of the tasks in this issue as well once this is done. Maybe I can push it in the same PR. Please let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants