Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing redundant has_XXX metadata functions in ColumnChunkMetadata #1332

Closed
alamb opened this issue Feb 17, 2022 · 0 comments · Fixed by #1346
Closed

Consider removing redundant has_XXX metadata functions in ColumnChunkMetadata #1332

alamb opened this issue Feb 17, 2022 · 0 comments · Fixed by #1346

Comments

@alamb
Copy link
Contributor

alamb commented Feb 17, 2022

The parquet column chunk metadata has_ methods for optional values in the metadata which are, strictly speaking, redundant with the methods that return Option

We should consider removing the other has_XXX methods

Originally posted by @shanisolomon in #1322 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove existing has_ methods for optional fields in ColumnChunkMetaData shanisolomon/arrow-rs
1 participant
@alamb