Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Reduce allocation in Substrait serde #41142

Open
westonpace opened this issue Apr 11, 2024 · 0 comments
Open

[C++] Reduce allocation in Substrait serde #41142

westonpace opened this issue Apr 11, 2024 · 0 comments

Comments

@westonpace
Copy link
Member

Describe the enhancement requested

Comment from review of #40696

You can use destination-passing style to avoid extra allocations with protobuf types:

    auto *user_defined = lit_->mutable_user_defined();
    user_defined->set_type_reference(anchor);
    value.PackTo(user_defined->mutable_value());

This will improve the performance of the Substrait serde

Component(s)

C++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant