Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Arrow build failed with error C2039 #42027

Closed
Cheney-W opened this issue Jun 7, 2024 · 3 comments
Closed

[C++] Arrow build failed with error C2039 #42027

Cheney-W opened this issue Jun 7, 2024 · 3 comments

Comments

@Cheney-W
Copy link

Cheney-W commented Jun 7, 2024

Describe the bug, including details regarding any error messages, version, and platform.

Hello, I'm a member of Microsoft VCPKG, when I built arrow:x64-windows in an internal version of Visual Studio, it failed with following errors:
arrow/json/object_writer.h(39): error C2039: 'string': is not a member of 'std'

This issue caused by the STL PR: microsoft/STL#4633, and according to the recommendations of the STL developers, the affected files need to include the Standard <string> header.

I have applied this change in vcpkg by microsoft/vcpkg#39160. Since this VS internal version has not been released yet, I am submitting this issue just to inform you.

Component(s)

C++

@raulcd
Copy link
Member

raulcd commented Jun 7, 2024

Thanks @Cheney-W for the report!

@raulcd raulcd changed the title Arrow build failed with error C2039 [C++] Arrow build failed with error C2039 Jun 7, 2024
@raulcd
Copy link
Member

raulcd commented Jun 7, 2024

It seems object_writer.h was already patched here:

@raulcd
Copy link
Member

raulcd commented Jun 7, 2024

Closing as already done but thanks for reporting.

@raulcd raulcd closed this as completed Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants