GH-40154: [C++][Parquet] Separate encoders and decoder #43972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Parquet
Component: C++
awaiting review
pitrou
force-pushed
the
gh40154-pq-encoding
branch
from
3e67757
to
be17259
Compare
|
@mapleFU @felipecrv @wgtmac This splits encoders and decoder into two separate files, but keeps a single |
|
I've checked that |
|
I just took a glimpse of it. It looks great! |
|
LGTM |
wgtmac
approved these changes
Sep 5, 2024
github-actions
bot
added
awaiting committer review
|
@github-actions crossbow submit -g cpp |
|
Revision: be17259 Submitted crossbow builds: ursacomputing/crossbow @ actions-d1fc910e2b
|
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c2123b8. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 9 possible false positives for unstable benchmarks that are known to sometimes produce them. |
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Sep 6, 2024
…43972) ### Rationale for this change `encoding.cc` is quite large nowadays : around 4000 lines of code, which makes code navigation cumbersome. It combines the functionality of encoders and decoders, however, those use distinct infrastructures and do not share any code. Other areas of Parquet tend to separate the reading and writing facilities: for example, `column_reader.cc` vs. `column_writer.cc`. ### What changes are included in this PR? The main change is to move encoders to `encoder.cc`, decoders to `decoder.cc`, and remove `encoding.cc`. A small improvement is also to remove the inclusion of `arrow/util/spaced.h` in `encoding.h` by moving the `TypedDecoder<T>::DecodeSpaced` implementation into `decoder.cc`. Note the massive code shuffle may obscure the git history quite a bit. `git log -C` doesn't seem able to track earlier versions of the encoder and decoder code, but `git blame -C` is. ### Are these changes tested? By existing tests. ### Are there any user-facing changes? No. * GitHub Issue: apache#40154 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
khwilson
pushed a commit
to khwilson/arrow
that referenced
this pull request
Sep 14, 2024
…43972) ### Rationale for this change `encoding.cc` is quite large nowadays : around 4000 lines of code, which makes code navigation cumbersome. It combines the functionality of encoders and decoders, however, those use distinct infrastructures and do not share any code. Other areas of Parquet tend to separate the reading and writing facilities: for example, `column_reader.cc` vs. `column_writer.cc`. ### What changes are included in this PR? The main change is to move encoders to `encoder.cc`, decoders to `decoder.cc`, and remove `encoding.cc`. A small improvement is also to remove the inclusion of `arrow/util/spaced.h` in `encoding.h` by moving the `TypedDecoder<T>::DecodeSpaced` implementation into `decoder.cc`. Note the massive code shuffle may obscure the git history quite a bit. `git log -C` doesn't seem able to track earlier versions of the encoder and decoder code, but `git blame -C` is. ### Are these changes tested? By existing tests. ### Are there any user-facing changes? No. * GitHub Issue: apache#40154 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
encoding.ccis quite large nowadays : around 4000 lines of code, which makes code navigation cumbersome. It combines the functionality of encoders and decoders, however, those use distinct infrastructures and do not share any code.Other areas of Parquet tend to separate the reading and writing facilities: for example,
column_reader.ccvs.column_writer.cc.What changes are included in this PR?
The main change is to move encoders to
encoder.cc, decoders todecoder.cc, and removeencoding.cc.A small improvement is also to remove the inclusion of
arrow/util/spaced.hinencoding.hby moving theTypedDecoder<T>::DecodeSpacedimplementation intodecoder.cc.Note the massive code shuffle may obscure the git history quite a bit.
git log -Cdoesn't seem able to track earlier versions of the encoder and decoder code, butgit blame -Cis.Are these changes tested?
By existing tests.
Are there any user-facing changes?
No.