CASSGO-11 Support vector type #1828
Conversation
|
Have you tested it with protoV5? If not I would be glad to handle it with #1822. |
Hmm protocol v5 shouldn't matter much here, the encoding of the type itself is the same regardless of whether v4 or v5 is being used. |
marshal.go
Outdated
| } | ||
| if k == reflect.Array { | ||
| if rv.Len() != info.Dimensions { | ||
| return unmarshalErrorf("unmarshal vector: array with wrong size") |
There was a problem hiding this comment.
NIT: maybe add the expected and provided sizes to the error message
vector_test.go
Outdated
| {name: "smallint", cqlType: TypeSmallInt.String(), value: []int16{127, 256, -1234}}, | ||
| {name: "tinyint", cqlType: TypeTinyInt.String(), value: []int8{127, 9, -123}}, | ||
| {name: "duration", cqlType: TypeDuration.String(), value: []Duration{duration1, duration2, duration3}}, | ||
| // TODO(lantonia): Test vector of custom types |
There was a problem hiding this comment.
NIT: a couple of TODOs in this test still
| @@ -197,5 +242,6 @@ jobs: | |||
| sleep 30s | |||
| - name: Integration tests | |||
| run: | | |||
| source ~/venv/bin/activate | |||
There was a problem hiding this comment.
just a reminder to remove the workflow changes from this PR before wrapping up (we'll have to potentially merge #1833 first) when we get a second +1
There was a problem hiding this comment.
Yes, this PR will wait for #1833. I will remove workflow changes form this PR, rebase and squash commits.
Fix #1734.
Complete vector type support for GoCQL. Supports fixed and variable-length vector types (e.g. vector of floats, vector of list of text).