Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Set StatusBarStyle from config.xml #728

Closed
mrbberra opened this issue Jun 12, 2020 · 3 comments · Fixed by #765
Closed

[iOS] Set StatusBarStyle from config.xml #728

mrbberra opened this issue Jun 12, 2020 · 3 comments · Fixed by #765

Comments

@mrbberra
Copy link
Contributor

Feature Request

Motivation Behind Feature

With the merge of GH-656, the status bar now shows up with the color of the app status bar, which I've been setting using cordova-plugin-statusbar. The InAppBrowser, however, still overrides the text in the status bar with UIStatusBarStyleDefault (black text), which is a problem if the status bar has a dark background color.

Example

  StatusBar.styleLightContent();
  StatusBar.backgroundColorByHexString("#281e36");

Screen Shot 2020-06-12 at 1 13 09 PM

Screen Shot 2020-06-12 at 1 13 16 PM

Feature Description

Set IAB iOS status bar color from the cordova config file. I'm imagining something like <preference name="InAppBrowserStatusBarStyle" value="lightcontent" />

I've got some work on this I've started I can submit a PR for- just changing the preferredStatusBarStyle. I guess a more complex implementation would be to add a method to modify it dynamically (since you can modify the status bar color dynamically using that plugin)... seems like overkill to me though.

@DaveRand
Copy link

I have a similar requirement except I need to set the statusbar background color dynamically as well as setting the statusbar text color to white.

@mosabab
Copy link
Contributor

mosabab commented Aug 25, 2020

I have same issue here for dark theme, because statusbar at inappbrowser plugin always read the default style (black text).

dpa99c added a commit that referenced this issue Sep 1, 2020
(ios) Add InAppBrowserStatusBarStyle preference. Resolves #728
@herne12
Copy link

herne12 commented Sep 9, 2022

Have you been able to fix the incident?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants