Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forward the CLI user arguments to cordova-serve/browser #18

Open
Max104t opened this issue Oct 18, 2019 · 5 comments · May be fixed by #42
Open

forward the CLI user arguments to cordova-serve/browser #18

Max104t opened this issue Oct 18, 2019 · 5 comments · May be fixed by #42

Comments

@Max104t
Copy link

Max104t commented Oct 18, 2019

Feature Request

Motivation Behind Feature

I'm trying to pass --allow-file-access-from-files --disable-web-security to chromium, and it seems that cordova-serve/src/browser and callers are dropping the command line arguments.

Where should I forward this feature request? Thanks!

Feature Description

Forward the CLI user arguments to cordova-serve/src/browser from cordova-browser:

return server.launchBrowser({
    target: args.target,
    url: projectUrl,
    userArgs: args.remain
});

Then pass these arguments to the browser during launch in cordova-serve/src/browser

module.exports = function (opts) {
    var userArgs = opts.userArgs || '';
     /* ... */

function getBrowser (target, dataDir, userArgs) {
    /* ... */
}

Alternatives or Workarounds

Launch chrome manually and let the default instance handle local host launching

Max104t added a commit to Max104t/cordova-serve that referenced this issue Oct 20, 2019
@brunobertechini
Copy link

Is this implemented already ?

@Max104t
Copy link
Author

Max104t commented Apr 13, 2020

yes, I can send a merge request!

@NiklasMerz
Copy link
Member

@Max104t This looks like a good change. It would be nice if you could submit a pull request with your commit as it looks well done.

@Max104t
Copy link
Author

Max104t commented Feb 17, 2021

My account is locked.. please feel free to fork and merge my branch..

@timbru31 timbru31 linked a pull request Feb 17, 2021 that will close this issue
5 tasks
@timbru31
Copy link
Member

I've gone ahead and created #42 while retaining your original commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants