Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugins] Convert to eslint #123

Closed
4 tasks
janpio opened this issue Jun 13, 2019 · 3 comments
Closed
4 tasks

[Plugins] Convert to eslint #123

janpio opened this issue Jun 13, 2019 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed plugins

Comments

@janpio
Copy link
Member

janpio commented Jun 13, 2019

Some plugins are still using jshint or no linting at all. Those should be converted to use eslint as most Cordova core plugins already do.

To convert:

@janpio janpio added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers plugins labels Jun 13, 2019
@GedasGa
Copy link

GedasGa commented Jun 18, 2019

cordova-plugin-screen-orientation does have jshint.

And I don't think we need linting in cordova-plugin-whitelist. It only has one .java file.

I'll try to proceed with others.

@janpio
Copy link
Member Author

janpio commented Jun 18, 2019

Updated the TODO (and linked issues) per your comment

@breautek
Copy link
Contributor

breautek commented Aug 5, 2020

Closing in favour of a much more progressed tracking ticket at #142

@breautek breautek closed this as completed Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed plugins
Projects
None yet
Development

No branches or pull requests

3 participants