Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for LargeString and LargeBinary for StringView and BinaryView #11023

Closed
Tracked by #10918
alamb opened this issue Jun 20, 2024 · 2 comments
Closed
Tracked by #10918

Support for LargeString and LargeBinary for StringView and BinaryView #11023

alamb opened this issue Jun 20, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Jun 20, 2024

Is your feature request related to a problem or challenge?

Part of #10918, [StringViewArray](https://docs.rs/arrow/latest/arrow/array/type.StringViewArray.html) support in DataFusion

@Weijun-H added support for <> and != forStringView in #10985 and @PsiACE added support for BinaryView in #11004

We also need similar support for LargeBinary and LargeUtf8 types

Describe the solution you'd like

Please remember to create a PR that targets the string-view branch (not main)

In order to improve performance of these queries we will need the ability to actually compare StringViewArrays to constant values (and likely to each other)

Thus I would like to be able to run

LargeUtf8 = StringView
StringView = LargeUtf8
LargeBinary = BinaryView
BinaryView = LargeBinary

Describe alternatives you've considered

I think you can follow the model in #11004 and simply extend the tests to have another column of LargeString and LargeBinary

Additional context

No response

@alamb alamb changed the title Implement support for LargeString and LargeBinary for StringView and BinaryView Support for LargeString and LargeBinary for StringView and BinaryView Jun 20, 2024
@alamb alamb added the enhancement New feature or request label Jun 20, 2024
@XiangpengHao
Copy link
Contributor

take

@alamb
Copy link
Contributor Author

alamb commented Jul 31, 2024

done in #11034 I think

@alamb alamb closed this as completed Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants