Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Up Data Page Statistics Tests and Fix Bug #11235

Closed
efredine opened this issue Jul 3, 2024 · 1 comment · Fixed by #11236
Closed

Clean Up Data Page Statistics Tests and Fix Bug #11235

efredine opened this issue Jul 3, 2024 · 1 comment · Fixed by #11236
Assignees
Labels
enhancement New feature or request

Comments

@efredine
Copy link
Contributor

efredine commented Jul 3, 2024

Is your feature request related to a problem or challenge?

Part of #10922

We have nearly completed adding APIs to efficiently convert the data stored in Parquet's "PageIndex" into ArrayRefs but I notice there are several tests that have not been converted from Check::RowGroup to Check::Both.

Describe the solution you'd like

It's likely they've just been missed, so probably as simple as changing them to Check::Both. I recognize at least a couple I missed from one of my PR's ;-). If it ends up more complicated than that I'll raise an issue or ask for help.

Describe alternatives you've considered

No response

Additional context

No response

@efredine efredine added the enhancement New feature or request label Jul 3, 2024
@efredine
Copy link
Contributor Author

efredine commented Jul 3, 2024

take

@efredine efredine changed the title Clean Up Data Page Statistics Tests Clean Up Data Page Statistics Tests and Fix Bug Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant