You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem or challenge?
Now two part aggregate hash table is used in datafusion, and we actually saved the hashes of groups in the hash table part.
But I found the saved hashes are not used during probing bucket, and we directly get group values and comapre instead, that will lead to many random memory accesses, and the compare operations are not cheap for some types.
Describe the solution you'd like
Maybe we should check the saved hashes first, and only check the group values when hashes are same for avoid collision.
Describe alternatives you've considered
No response
Additional context
I run the clickbench in local, it seems help to some cases.
Rachelint
changed the title
Check saved hash first during probing bucket in hash map
Check saved hash first during probing bucket in aggr hash table
Jul 30, 2024
Is your feature request related to a problem or challenge?
Now two part aggregate hash table is used in datafusion, and we actually saved the
hashes
ofgroups
in thehash table
part.But I found the saved
hashes
are not used during probing bucket, and we directly getgroup values
and comapre instead, that will lead to many random memory accesses, and the compare operations are not cheap for some types.Describe the solution you'd like
Maybe we should check the saved
hashes
first, and only check thegroup values
whenhashes
are same for avoid collision.Describe alternatives you've considered
No response
Additional context
I run the clickbench in local, it seems help to some cases.
The text was updated successfully, but these errors were encountered: