-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move LogicalPlan to datafusion-expr crate #2245
Comments
Would it make sense to call this crate 'datafusion-logical-plan' after this change? At least to me it wouldn't be immediately obvious that logical plan was there from naming. But maybe that's just me. |
Yes, that would make more sense to me too. |
So this doesn't look like it can work. The logical plan depends on the datasource module, which depends on the physical plan 😞
|
We need to address #2247 before we can make progress on this issue |
+1 |
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
I am trying to implement support for the expression
EXISTS (<subquery>)
and this requires having a newExpr
variant that refers to aLogicalPlan
. However, this is not possible becauseLogicalPlan
is in the coredatafusion
crate which depends on thedatafusion-expr
crate that containsExpr
, and therefore it is not possible to referenceLogicalPlan
fromExpr
.Describe the solution you'd like
LogicalPlan
andExpr
should live in the same crate IMO so I propose movingLogicalPlan
into thedatafusion-expr
crate.Describe alternatives you've considered
None
Additional context
See the discussion in #2181 for more context
The text was updated successfully, but these errors were encountered: