Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The upcoming release of Arrow (20?) breaks datafusion #3006

Closed
avantgardnerio opened this issue Aug 1, 2022 · 4 comments · Fixed by #3083
Closed

The upcoming release of Arrow (20?) breaks datafusion #3006

avantgardnerio opened this issue Aug 1, 2022 · 4 comments · Fixed by #3083
Labels
enhancement New feature or request

Comments

@avantgardnerio
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Some changes to Decimal 128 & 256 require updating datafusion code to support.

Describe the solution you'd like

Decimal 128 to be supported.

Describe alternatives you've considered

I think we're going to have to do this.

Additional context

N/A

@avantgardnerio avantgardnerio added the enhancement New feature or request label Aug 1, 2022
@alamb
Copy link
Contributor

alamb commented Aug 3, 2022

I think this has been resolved in #3007

@avantgardnerio
Copy link
Contributor Author

I think this has been resolved in #3007

The build is fully working in CI and for me locally, yes. There are still some failing checks I haven't looked into. Would you like me to undraft #3007?

@alamb
Copy link
Contributor

alamb commented Aug 3, 2022

The build is fully working in CI and for me locally, yes. There are still some failing checks I haven't looked into. Would you like me to undraft #3007?

I don't have any strong preference

@liukun4515
Copy link
Contributor

there are many api changes for decimal in arrow-rs.
upgrading the arrow-rs 20 for datafusion need to take effort.
Thanks for your work. @avantgardnerio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants