Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TableProviderFactory::create should have Optional<DFSchemaRef> parameter #4142

Closed
milenkovicm opened this issue Nov 8, 2022 · 0 comments · Fixed by #4143
Closed

TableProviderFactory::create should have Optional<DFSchemaRef> parameter #4142

milenkovicm opened this issue Nov 8, 2022 · 0 comments · Fixed by #4143
Labels
enhancement New feature or request

Comments

@milenkovicm
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

datafusion::datasource::datasource::TableProviderFactory::create should have Optional<DFSchemaRef> a parameter to support statements with table DDL e.g: CREATE EXTERNAL TABLE demo_table (c1 integer, c2 integer) STORED AS ... ?

Describe the solution you'd like

add schema: Optional<DFSchemaRef> to method signature

Describe alternatives you've considered

use schema: DFSchemaRef as parameter, which can be empty. I've believe version with Optional make more sense, as it is easier to understand.

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant