Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement the eliminate_cross_join #4176

Closed
Tracked by #4267
jackwener opened this issue Nov 11, 2022 · 0 comments · Fixed by #4185
Closed
Tracked by #4267

Reimplement the eliminate_cross_join #4176

jackwener opened this issue Nov 11, 2022 · 0 comments · Fixed by #4185
Labels
bug Something isn't working

Comments

@jackwener
Copy link
Member

Describe the bug
Current implementation of eliminate_cross_join is wrong.
Because it can't rearrange join order.

When original plan is

filter: a.id = b.id and a.id = c.id
  crossjoin a  (bc)
    crossjoin b c

it will become 

filter: a.id = b.id and a.id = c.id
  inner a (bc) on a.id = b.id and a.id = c.id
    crossjoin b c

I will reimplement eliminate_cross_join to resolve this problem.

To Reproduce
Steps to reproduce the behavior:

Expected behavior
A clear and concise description of what you expected to happen.

Additional context
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant