Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings about incorrect README location when publishing crates #5596

Closed
andygrove opened this issue Mar 14, 2023 · 1 comment
Closed

Warnings about incorrect README location when publishing crates #5596

andygrove opened this issue Mar 14, 2023 · 1 comment
Assignees
Labels
bug Something isn't working development-process Related to development process of DataFusion

Comments

@andygrove
Copy link
Member

andygrove commented Mar 14, 2023

Describe the bug

There was a recent change to add a [workspace.package] section in the top level Cargo.toml, with the readme specified there. This does not appear to be working as intended, as it is trying to publish the top-level README in each crate.

warning: readme `../../README.md` appears to be a path outside of the package, but there is already a file named `README.md` in the root of the package. The archived crate will contain the copy in the root of the package. Update the readme to point to the path relative to the root of the package to remove this warning.

To Reproduce

Expected behavior

Additional context

@andygrove andygrove added the bug Something isn't working label Mar 14, 2023
@andygrove andygrove self-assigned this Mar 14, 2023
@andygrove andygrove added the development-process Related to development process of DataFusion label Mar 14, 2023
@alamb
Copy link
Contributor

alamb commented Oct 29, 2023

Closed by #7964

@alamb alamb closed this as completed Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working development-process Related to development process of DataFusion
Projects
None yet
Development

No branches or pull requests

2 participants