Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests in datafusion-common failed #7933

Open
Weijun-H opened this issue Oct 26, 2023 · 3 comments
Open

Tests in datafusion-common failed #7933

Weijun-H opened this issue Oct 26, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@Weijun-H
Copy link
Member

Describe the bug

After #7745, the tests in 'datafusion-common' didn't work.

To Reproduce

cargo test --package datafusion-common

Expected behavior

Pass all tests

Additional context

Related

@Weijun-H Weijun-H added the bug Something isn't working label Oct 26, 2023
@Weijun-H Weijun-H changed the title Tests in datafusion-common failure Tests in datafusion-common failed Oct 26, 2023
@ongchi
Copy link
Contributor

ongchi commented Oct 26, 2023

I think this would be resolved by adding parquet into default feature of datafusion-common package.

[features]
default = ["parquet"]

I'm thoughtless to test every package individually. Maybe we should add some CI tests for packages?

@Weijun-H
Copy link
Member Author

I think this would be resolved by adding parquet into default feature of datafusion-common package.

[features]
default = ["parquet"]

I'm thoughtless to test every package individually. Maybe we should add some CI tests for packages?

I think so, it would be nice to test for packages. But I am not sure if it is necessary.

@alamb
Copy link
Contributor

alamb commented Oct 26, 2023

I'm thoughtless to test every package individually. Maybe we should add some CI tests for packages?

Perhaps we can extend this check:

https://github.com/apache/arrow-datafusion/blob/main/.github/workflows/rust.yml#L69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants