Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bloom filter statistics to ParquetExec #8767

Closed
alamb opened this issue Jan 5, 2024 · 0 comments · Fixed by #8772
Closed

Add bloom filter statistics to ParquetExec #8767

alamb opened this issue Jan 5, 2024 · 0 comments · Fixed by #8772
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Jan 5, 2024

Is your feature request related to a problem or challenge?

It appears that there is no good way to know if the bloom filter code is working via logging or metrics 🤔

We have metrics on ParquetExec that explain when row groups are pruned, but now that we can prune them via statistics or bloom filters, we can't tell which was used in a particular query

Among other things this meant it was hard to reproduce / diagnose issues like #8685

Describe the solution you'd like

Add some metrics for parquet pruning

Describe alternatives you've considered

@my-vegetable-has-exploded has a branch that could be a good starting point:
I check it by the metric I add myself(like https://github.com/apache/arrow-datafusion/compare/main...my-vegetable-has-exploded:arrow-datafusion:metric-sbbf?expand=1) , Should

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant