Test failure in sqllogictest aggregates_topk.slt on mac

[alamb]

Describe the bug

sqllogic

External error: query result mismatch:
[SQL] select trace_id, other, MIN(timestamp) from traces group by trace_id, other order by MIN(timestamp) asc limit 4;
[Diff] (-expected|+actual)
    a -1 -1
    b 0 0
    NULL 0 0
-   c 1 1
+   a 1 1
at test_files/aggregate.slt:2566

To Reproduce

I run this on my Mac M3:

cargo test --test sqllogictests

Expected behavior

The test should pass

Additional context

No response

[alamb]

@mustafasrepo moved this intermittent test to aggregates_topk.slt to isolate the problem more in #8948

@avantgardnerio this is now coming up in new PRs -- e.g. #8993

Can you suggest some way to make these tests deterministic (maybe we need to add a few more rows or adjust N so the top K rows are well defined in all cases?

[avantgardnerio]

@alamb , sorry for the flaky test 😞 . I can think of two solutions:

1. turn this into a unit test that asserts content, but not order
2. go all the way and implement multiple order bys with OwnedRow and add a 2nd order by to the test

[mustafasrepo]

What about changing timestamp field in the table so that, it is unique (hence MIN(timestamp) will generate different results for each different distinct group).

[mustafasrepo]

What about changing timestamp field in the table so that, it is unique (hence MIN(timestamp) will generate different results for each different distinct group).

Filed a mini PR8998 implementing this suggestion. It will be nice if you have time to double check whether result is indeed deterministic.